Primitive List feature(Part8: Annotation processor implementation)#5210
Merged
zaki50 merged 52 commits intofeature/primitive_listfrom Sep 15, 2017
Merged
Conversation
…notation_processor
…notation_processor
…notation_processor
…notation_processor
…notation_processor
…_8_annotation_processor
zaki50
changed the base branch from
my/primitive_list_7_Schema
to
mc/primitive_list_10_oslist_JNI
…_8_annotation_processor
…_8_annotation_processor
…_8_annotation_processor
…_8_annotation_processor
…_8_annotation_processor
…_8_annotation_processor
…_8_annotation_processor
…_8_annotation_processor
beeender
reviewed
Sep 13, 2017
|
|
||
| Property(String name, RealmFieldType type, @Nullable String linkedClassName) { | ||
| Property(String name, RealmFieldType type, @Nullable String linkedClassName, boolean required) { | ||
| // Ignore the isRequired when creating the linking property. |
Contributor
There was a problem hiding this comment.
this comment can be removed
Contributor
Author
There was a problem hiding this comment.
I missed this comment. I'll remove this comment in part 9
…_8_annotation_processor
…_8_annotation_processor
…_8_annotation_processor
…_8_annotation_processor
…pe more precisely
…_8_annotation_processor
…_8_annotation_processor
beeender
force-pushed
the
mc/primitive_list_10_oslist_JNI
branch
2 times, most recently
from
b2bc65a to
815bad7
Compare
beeender
approved these changes
Sep 14, 2017
| .emitStatement("unmanaged%1$sList.add(managed%1$sList.get(i))", fieldName) | ||
| .endControlFlow() | ||
| .endControlFlow("while (false)"); | ||
| .emitStatement("unmanagedCopy.%1$s(new RealmList<%2$s>())", setter, Utils.getGenericTypeQualifiedName(field)) |
Contributor
Author
|
@realm/java All comments are addressed. I'll merge this if no further comments. |
zaki50
changed the base branch from
mc/primitive_list_10_oslist_JNI
to
feature/primitive_list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on Part 10 (#5216)