Primitive List feature(Part 9, RealmList)#5213
Merged
zaki50 merged 137 commits intofeature/primitive_listfrom Sep 19, 2017
Merged
Primitive List feature(Part 9, RealmList)#5213zaki50 merged 137 commits intofeature/primitive_listfrom
zaki50 merged 137 commits intofeature/primitive_listfrom
Conversation
zaki50
changed the title
…tive_list_9_RealmList
…notation_processor
…tive_list_9_RealmList
…notation_processor
…notation_processor
…notation_processor
…tive_list_9_RealmList
…notation_processor
…tive_list_9_RealmList
…tive_list_9_RealmList
…tive_list_9_RealmList
…tive_list_9_RealmList
Contributor
Author
|
I've addressed all comment. Could you give second-round review? @realm/java |
beeender
approved these changes
Sep 19, 2017
|
|
||
| * `RealmResults.distinct()`/`RealmResults.distinctAsync()` have been removed. Use `RealmQuery.distinct()`/`RealmQuery.distinctAsync()` instead. | ||
| * `RealmQuery.createQuery(Realm, Class)`, `RealmQuery.createDynamicQuery(DynamicRealm, String)`, `RealmQuery.createQueryFromResult(RealmResults)` and `RealmQuery.createQueryFromList(RealmList)` have been removed. Use `Realm.where(Class)`, `DynamicRealm.where(String)`, RealmResults.where()` and `RealmList.where()` instead. | ||
| * Some exception messages are revised. |
Contributor
There was a problem hiding this comment.
this is not serious breaking change i guess :P put it to enhancement or just remove?
| } | ||
|
|
||
| /** | ||
| * This class provides façade for against {@link OsList}. {@link OsList} is used for both {@link RealmModel}s |
Contributor
There was a problem hiding this comment.
façade -> facade ç here (I thought my monitor was dirty)
Contributor
Author
There was a problem hiding this comment.
façade is correct word, but I don't mind to fix this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on Part 8 (#5210)