Skip to content

Primitive List feature(Part 13, Support listener on OsList) #5259

Merged
zaki50 merged 147 commits intofeature/primitive_listfrom
mc/primitive_list_13_Listener_on_OsList
Sep 19, 2017
Merged

Primitive List feature(Part 13, Support listener on OsList) #5259
zaki50 merged 147 commits intofeature/primitive_listfrom
mc/primitive_list_13_Listener_on_OsList

Conversation

@beeender
Copy link
Copy Markdown
Contributor

@beeender beeender commented Sep 14, 2017 •
edited
Loading

  • Reuse the logic for Collection(OsResults) to support adding listeners
    on OsList.
  • Use OsList to handle notifications of primitive list.
  • Keep the current logic for RealmModel list -- handle notifications
    with a OsResults which is created from the OsList.

This is based on #5213

zaki50 added 30 commits September 6, 2017 04:06
@zaki50
generate getters and setters for primitive list
88ece6e
@zaki50
empty commit for part9
d86453f
@zaki50
implement logic for primitive list in RealmList
81d4061
@zaki50
fix tests
14489f7
@zaki50
fix annotation processor unit tests
c48d399
@zaki50
Merge branch 'my/primitive_list_8_annotation_processor' into my/primi…
6c8b329 
…tive_list_9_RealmList
@zaki50
Merge branch 'my/primitive_list_7_Schema' into my/primitive_list_8_an…
d4333f1 
…notation_processor
@zaki50
Merge branch 'my/primitive_list_8_annotation_processor' into my/primi…
b305367 
…tive_list_9_RealmList
@zaki50
throw an exception if query or aggregation feature is used for primit…
c48bee2 
…ive list
@zaki50
Merge branch 'my/primitive_list_7_Schema' into my/primitive_list_8_an…
7c420cc 
…notation_processor
@zaki50
Merge branch 'my/primitive_list_7_Schema' into my/primitive_list_8_an…
392a877 
…notation_processor
@zaki50
Merge branch 'my/primitive_list_7_Schema' into my/primitive_list_8_an…
395fc8b 
…notation_processor
@zaki50
fix tests
86bd3d4
@zaki50
Merge branch 'my/primitive_list_8_annotation_processor' into my/primi…
a097d8f 
…tive_list_9_RealmList
@zaki50
Merge branch 'my/primitive_list_7_Schema' into my/primitive_list_8_an…
ba3daaa 
…notation_processor
@zaki50
Merge branch 'my/primitive_list_8_annotation_processor' into my/primi…
2b007a4 
…tive_list_9_RealmList
@zaki50
address findbugs issues
84aca51
@zaki50
added Javadoc comment and RealmList.toArray()
94b109b
@zaki50
fix bug
04c04c1
@zaki50
Merge branch 'my/primitive_list_8_annotation_processor' into my/primi…
c505b4d 
…tive_list_9_RealmList
@zaki50
implement Primitive List logic for copy() and insert()
c1d2396
@zaki50
Merge branch 'my/primitive_list_8_annotation_processor' into my/primi…
9654a68 
…tive_list_9_RealmList
@zaki50
implement Primitive List logic for insert(Realm, Iterator,...)
5243cd6
@zaki50
Merge branch 'my/primitive_list_8_annotation_processor' into my/primi…
36c23ec 
…tive_list_9_RealmList
@zaki50
generate code for primitive list in update(), insertOrUpdate()
7cc7ae5
@zaki50
Merge branch 'my/primitive_list_8_annotation_processor' into my/primi…
8fb4430 
…tive_list_9_RealmList
@zaki50
minor refactoring
535563c
@zaki50
Merge branch 'my/primitive_list_7_Schema' into my/primitive_list_8_an…
4e16256 
…notation_processor
@zaki50
Merge branch 'my/primitive_list_8_annotation_processor' into my/primi…
3a9cc02 
…tive_list_9_RealmList
@zaki50
implement primitive list supprt for copyFromRealm()
53d88ee
zaki50 added 26 commits September 16, 2017 15:33
@zaki50
Using constans defined in Table class
bb43a16
@zaki50
use assertArrayEquals() instead of assertTrue(Arrays.equals())
4f5cb68
@zaki50
add changelog entry about removed methods
5e0b43c
@zaki50
remove unused code
a3e2407
@zaki50
update comment
b7d0167
@zaki50
remove comment
f27b2a2
@zaki50
update exception message
e9e960d
@zaki50
update thrown.expectMessage() to check exception message
4acc4a2
@zaki50
fix test case name
676a11b
@zaki50
add assertion for remove/removeAll
b33bb8e
@zaki50
update RealmList.toString()
b7b59bd
@zaki50
update exception message
a12c0c3
@zaki50
fix failing tests
88ed4ba
@zaki50
remove special handling to byte array in RealmList
06d562d
@zaki50
remove special type conversion via Number in toArray()
40b1ac2
@zaki50
Merge branch 'my/primitive_list_9_RealmList' into mc/primitive_list_1…
5817352 
…3_Listener_on_OsList
@zaki50
fix failing tests
4ff447d
@zaki50
remove unnecessary index checks
90affd1
@zaki50
refactor ManagedListOperator and its sub-classes
38bd2bc
@zaki50
use thrown.expectMessage()
c871e8a
@zaki50
add Javadoc comments to ManagedListOperator and its subclasses
93a4037
@zaki50
Merge branch 'feature/primitive_list' into my/primitive_list_9_RealmList
e4de8b3
@zaki50
Merge branch 'my/primitive_list_9_RealmList' into mc/primitive_list_1…
d798e2d 
…3_Listener_on_OsList
@zaki50
address review comments
c50e0a3
@zaki50
Merge branch 'my/primitive_list_9_RealmList' into mc/primitive_list_1…
a1f3d7b 
…3_Listener_on_OsList
@zaki50
Merge branch 'feature/primitive_list' into mc/primitive_list_13_Liste…
9b691ac 
…ner_on_OsList
@zaki50 zaki50 changed the base branch from my/primitive_list_9_RealmList to feature/primitive_list September 19, 2017 12:46
@zaki50 zaki50 merged commit e0bb50c into feature/primitive_list Sep 19, 2017
@zaki50 zaki50 deleted the mc/primitive_list_13_Listener_on_OsList branch September 19, 2017 12:51
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@cmelchior cmelchior cmelchior approved these changes

@zaki50 zaki50 zaki50 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@beeender beeender

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@beeender @cmelchior @zaki50