Skip to content

Primitive List feature(Part15: Disable RealmList.createSnapshot() when the elements are not RealmModel)#5336

Merged
zaki50 merged 5 commits intofeature/primitive_listfrom
my/primitive_list_15_misc
Sep 29, 2017
Merged

Primitive List feature(Part15: Disable RealmList.createSnapshot() when the elements are not RealmModel)#5336
zaki50 merged 5 commits intofeature/primitive_listfrom
my/primitive_list_15_misc

Conversation

@zaki50
Copy link
Copy Markdown
Contributor

@zaki50 zaki50 commented Sep 28, 2017

No description provided.

@zaki50 zaki50 mentioned this pull request Sep 28, 2017
21 tasks
@zaki50 zaki50 changed the title Disable RealmList.createSnapshot() Disable RealmList.createSnapshot() when the elements are not RealmModel Sep 28, 2017
Copy link
Copy Markdown
Contributor

@cmelchior cmelchior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog entries doesn't seem relevant to this PR , but I guess they were just missing in general so 👍

Comment thread CHANGELOG.md Outdated
## Enhancements

* Support list of values as a field of model class. Now users can use `String`, `byte[]`, `Boolean`, `Long`, `Integer`, `Short`, `Byte`, `Double`, `Float` and `Date` as a type parameter of `RealmList`.
* Supported list of values as a field of model class. Now users can use `String`, `byte[]`, `Boolean`, `Long`, `Integer`, `Short`, `Byte`, `Double`, `Float` and `Date` as a type parameter of `RealmList`.
Copy link
Copy Markdown
Contributor

@Zhuinden Zhuinden Sep 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is right. It's supported only if it's something like, List of values are now supported as a field of model class. Although the next sentence defines it better anyways :D

@zaki50 zaki50 changed the title Disable RealmList.createSnapshot() when the elements are not RealmModel Primitive List feature(Part15: Disable RealmList.createSnapshot() when the elements are not RealmModel) Sep 29, 2017
@zaki50 zaki50 merged commit 2cd1e3e into feature/primitive_list Sep 29, 2017
@zaki50 zaki50 deleted the my/primitive_list_15_misc branch September 29, 2017 06:06
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants