Skip to content

Primitive List feature(Part15: Disable RealmList.createSnapshot() when the elements are not RealmModel) #5336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zaki50 merged 5 commits into from
Sep 29, 2017
+14 −1
Merged

Primitive List feature(Part15: Disable RealmList.createSnapshot() when the elements are not RealmModel) #5336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
34cdb80
disable RealmList.createSnapshot()
zaki50 Sep 28, 2017
311d37f
add changelog entry of primitive list
zaki50 Sep 28, 2017
aedd47e
fix CHANGELOG.md
zaki50 Sep 28, 2017
8c03bac
fix CHANGELOG.md
zaki50 Sep 28, 2017
c3bf346
update CHANGELOG.md
zaki50 Sep 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,14 @@
* Removed deprecated API `RealmObject.removeChangeListeners()`. Use `RealmObject.removeAllChangeListeners()` instead.
* `SyncUser.Callback` to becomes generic.
* Removed `SyncUser.getAccessToken` method from public API, and rename it to `getRefreshToken`.
* Relaxed upper bound of type parameter of `RealmList`, `RealmQuery`, `RealmResults`, `RealmCollection`, `OrderedRealmCollection` and `OrderedRealmCollectionSnapshot`.

## Deprecated

## Enhancements

* Now users can use `String`, `byte[]`, `Boolean`, `Long`, `Integer`, `Short`, `Byte`, `Double`, `Float` and `Date` as a type parameter of `RealmList`.

## Bug Fixes

## Internal
Expand Down
7 changes: 7 additions & 0 deletions realm/realm-library/src/androidTest/java/io/realm/ManagedRealmListForValueTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1552,4 +1552,11 @@ public void onChange(RealmList<Object> collection, @Nullable OrderedCollectionCh
realm.commitTransaction();
assertEquals(1, listenerCalledCount.get());
}

@Test
public void createSnapshot() {
thrown.expect(IllegalStateException.class);
thrown.expectMessage(is(RealmList.ALLOWED_ONLY_FOR_REALM_MODEL_ELEMENT_MESSAGE));
list.createSnapshot();
}
}
5 changes: 4 additions & 1 deletion realm/realm-library/src/main/java/io/realm/RealmList.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
public class RealmList<E> extends AbstractList<E> implements OrderedRealmCollection<E> {

private static final String ONLY_IN_MANAGED_MODE_MESSAGE = "This method is only available in managed mode.";
private static final String ALLOWED_ONLY_FOR_REALM_MODEL_ELEMENT_MESSAGE = "This feature is available only when the element type is implementing RealmModel.";
static final String ALLOWED_ONLY_FOR_REALM_MODEL_ELEMENT_MESSAGE = "This feature is available only when the element type is implementing RealmModel.";
public static final String REMOVE_OUTSIDE_TRANSACTION_ERROR = "Objects can only be removed from inside a write transaction.";

@Nullable
Expand Down Expand Up @@ -754,6 +754,9 @@ public OrderedRealmCollectionSnapshot<E> createSnapshot() {
throw new UnsupportedOperationException(ONLY_IN_MANAGED_MODE_MESSAGE);
}
checkValidRealm();
if (!osListOperator.forRealmModel()) {
throw new IllegalStateException(ALLOWED_ONLY_FOR_REALM_MODEL_ELEMENT_MESSAGE);
}
if (className != null) {
return new OrderedRealmCollectionSnapshot<>(
realm,
Expand Down