Save full tokenURI data to config.json on ERC-8004 registration#165
Save full tokenURI data to config.json on ERC-8004 registration#165realproject7 merged 3 commits intomainfrom
Conversation
@re2 Review — REQUEST CHANGESThe code logic is clean and correct — one issue to fix before approval: 🔴 Version conflict in
|
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The change closes most of the gap, but it still does not persist the full tokenURI payload described in issue #163. The on-chain tokenURI includes registeredBy, and that field is still omitted from both config.json and the generate-binding response.
Findings
- [high] The registration flow still saves only a subset of the tokenURI payload.
agentURIincludesregisteredBy: "plotlink-ows", but the subsequentwriteConfig()call omits it, so the saved config does not fully reflect the registered tokenURI content.- File:
app/routes/settings.ts:112,app/routes/settings.ts:161 - Suggestion: persist
registeredByalongside the other tokenURI-derived fields inconfig.json.
- File:
- [medium]
generate-bindingstill returns only a subset of the cached tokenURI fields. IfregisteredByis part of the tokenURI payload we cache, it should be included here as well for consistency with the issue acceptance around full tokenURI data availability.- File:
app/routes/settings.ts:59 - Suggestion: add the cached
registeredByfield to the response, matching the saved config payload.
- File:
Decision
Requesting changes because the PR still saves and returns a partial tokenURI payload rather than the full registered content required by issue #163.
Persist agentLlmModel and agentRegisteredAt alongside existing fields after ERC-8004 registration. Include both in the generate-binding response for plotlink.xyz. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
9df8241 to
7b55c70
Compare
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
I re-reviewed the force-pushed head. It appears to be a rebase plus version bump only; the tokenURI completeness blocker is still present.
Findings
- [high]
app/routes/settings.ts:114still includesregisteredBy: "plotlink-ows"in the on-chain tokenURI, butapp/routes/settings.ts:160still omits that field fromwriteConfig(), soconfig.jsonstill does not reflect the full registered tokenURI content.- Suggestion: persist the cached
registeredByfield alongside the rest of the tokenURI-derived config.
- Suggestion: persist the cached
- [medium]
app/routes/settings.ts:67still omits the cachedregisteredByfield fromgenerate-binding, so the response is still only a partial view of the saved tokenURI payload.- Suggestion: include
registeredByin the response if you are caching the full tokenURI payload.
- Suggestion: include
Decision
Keeping this in request-changes state until the saved and returned config data matches the full tokenURI payload.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: COMMENT
Summary
The latest head addresses the missing tokenURI field. I found no remaining code blockers in the registration/config caching change.
Findings
- No remaining code blockers on the current diff.
Decision
Holding final approval until the current lint-and-typecheck run is green.
@re2 Re-review — APPROVE ✅All issues addressed:
Config now matches the full on-chain tokenURI payload: APPROVE |
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The registration/config caching change now matches the full tokenURI payload required by issue #163. The current head persists and returns the missing fields without changing the existing registration flow.
Findings
- No remaining blocking issues.
Decision
Approving because the implementation meets the acceptance criteria and lint-and-typecheck passed on the current head.
Summary
agentLlmModelandagentRegisteredAttoconfig.jsonafter ERC-8004 registration, matching the on-chain tokenURI payloadgenerate-bindingresponse for plotlink.xyzFixes #163
Test plan
~/.plotlink-ows/config.jsoncontains all tokenURI fieldsgenerate-bindingand verify response includesagentLlmModelandagentRegisteredAt🤖 Generated with Claude Code