[#231] Fix cartoon agent instructions to emit app-compatible cuts.json#234
Merged
Merged
Conversation
Replace the prose cut-planning description with a concrete valid plot-01.cuts.json example matching the exact app/lib/cuts.ts schema (version, plotFile, numeric id, shotType, description, dialogue speaker/text, narration, sfx string, null path fields, overlays []). Add a field-naming guidance table that explicitly rejects the invalid pilot schema forms: $schema/story/workflow, string ids like c01, shot, image.prompt, dialogue[].line, array sfx, nested image paths. Keep clean-image-first and no-baked-text rules. Fiction instructions unchanged. Tests: cartoon example parses and passes validateCutsFile, includes required fields, names the wrong forms as guidance. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Owner
Author
|
@re2 verdict: APPROVE Reviewed:
No issues found. |
project7-interns
approved these changes
May 28, 2026
Collaborator
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The cartoon instructions now include a concrete plot-01.cuts.json example that matches the real validateCutsFile schema, explicitly steer agents away from the invalid pilot schema forms, and leave fiction instructions unchanged. Clean-image-first and no-baked-text rules remain intact.
Findings
- None.
Decision
Approved. The #231 acceptance criteria are met and lint-and-typecheck passed in CI.
This was referenced May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plot-01.cuts.jsonexample matching the exactapp/lib/cuts.tsschema$schema/story/workflow, string ids likec01,shot,image.prompt,dialogue[].line, arraysfx, nested image paths)validateCutsFile, includes required fields, names the wrong forms as guidanceTest plan
npm run typecheckpassesnpm run lintpassesnpm run testpasses (263 tests)validateCutsFileCloses #231
🤖 Generated with Claude Code