[#232] Show actionable errors for invalid cartoon cuts.json#235
Merged
Conversation
CartoonPreview and CutListPanel now show an "Invalid cuts file" error with the exact validation message plus actionable guidance: the file must follow the OWS v1 schema, and the user should ask Claude to regenerate it using the v1 cuts schema. Missing files (404) still show "No cuts yet" — invalid files (400) are no longer silently treated as no cuts. No destructive reset action added (guidance-only recovery, per MVP safety requirement). Tests: frontend invalid-schema and invalid-JSON error display with v1 guidance, 404 still shows No cuts; backend route returns 404 for missing, 400 with validation error for wrong schema, 400 for malformed JSON. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Owner
Author
|
@re2 verdict: APPROVE Reviewed: Error display (CartoonPreview + CutListPanel):
404 vs 400 distinction (already correct, now surfaced):
Recovery: Guidance-only, no destructive reset — correct per MVP safety requirement (no deletion of user assets). Tests:
Fiction preview unchanged. No issues found. |
project7-interns
approved these changes
May 28, 2026
Collaborator
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
Invalid cartoon cuts files now surface visible, actionable OWS v1 schema errors in both preview and cut-list contexts, while missing cuts files still show the normal empty state. Backend tests cover missing, malformed JSON, and wrong-schema responses, and fiction behavior is not touched.
Findings
- None.
Decision
Approved. The #232 acceptance criteria are met and lint-and-typecheck passed in CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
npm run typecheckpassesnpm run lintpassesnpm run testpasses (270 tests)Closes #232
🤖 Generated with Claude Code