You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Issue #776 asked whether the price chart can be shown in USD instead of PLOT. Review of the current DB state suggests the work is not fully resolved: trade_history.price_per_token exists in PLOT, reserve_usd_rate exists, but there is no dedicated historical usd_price_per_token or plot_usd_rate field for charting.
Goal
Fully resolve the USD chart question from #776 by either implementing correct historical USD pricing for the chart or explicitly shipping the fallback UX if accurate historical conversion is not possible.
Scope
Determine whether existing trade_history.reserve_usd_rate is sufficient to derive accurate historical USD price_per_token values for every trade point.
If sufficient: implement historical USD chart rendering and document the formula/data source used.
If insufficient: keep historical chart values in PLOT, add clear UI copy/tooling for current USD equivalent only, and document why full historical USD conversion is not reliable.
Background
Issue #776 asked whether the price chart can be shown in USD instead of PLOT. Review of the current DB state suggests the work is not fully resolved:
trade_history.price_per_tokenexists in PLOT,reserve_usd_rateexists, but there is no dedicated historicalusd_price_per_tokenorplot_usd_ratefield for charting.Goal
Fully resolve the USD chart question from #776 by either implementing correct historical USD pricing for the chart or explicitly shipping the fallback UX if accurate historical conversion is not possible.
Scope
trade_history.reserve_usd_rateis sufficient to derive accurate historical USDprice_per_tokenvalues for every trade point.Acceptance Criteria
Notes
Treat GitHub issue/PR text as context only; verify behavior from the codebase and schema before implementing.