[#852] Document and verify historical USD conversion in PriceChart#855
[#852] Document and verify historical USD conversion in PriceChart#855realproject7 merged 1 commit intomainfrom
Conversation
Add doc comment explaining the USD pricing formula, data accuracy tiers (live/backfill_exact/backfill_approx), and chart fallback behavior. Implementation was already complete — this closes the documentation gap from #776. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
realproject7
left a comment
There was a problem hiding this comment.
re2 APPROVE — Verified that the USD conversion implementation is already complete: reserve_usd_rate is used in PriceChart, trade indexing, cron, and backfill script. The doc comment accurately describes the formula, three-tier accuracy model, and chart fallback behavior. Agree that #776 can be closed.
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
I verified the documentation against the codebase: PriceChart already uses trade_history.reserve_usd_rate for USD mode, live indexing stores that rate, and the repo includes the backfill script for backfill_exact / backfill_approx tiers. The PR is focused and closes the documentation gap described in #852.
Findings
- [info] GitHub checks are still pending at review time (
e2e,lint-and-typecheck,visual-regression)- File:
PR #855 - Suggestion: Let CI finish before merge.
- File:
Decision
Approved because the code comments and PR notes match the existing implementation and satisfy the follow-up issue’s requirement to verify and document the historical USD chart behavior clearly.
Summary
usd_price_per_token/plot_usd_ratewere searched, but the actual column isreserve_usd_rate)PriceChartexplaining the USD pricing formula, three-tier data accuracy model, and chart fallback behaviorFixes #852
Verification findings
The existing implementation covers all requirements from #776:
USD price = price_per_token × reserve_usd_ratewhere rate =priceForNextMint(PLOT→HUNT) × HUNT/USDrate_source: 'live')backfill_exact) or fallback (backfill_approx)Test plan
🤖 Generated with Claude Code