[#175] Show Claim Royalties always with disabled state and tooltip#182
Merged
realproject7 merged 1 commit intomainfrom Mar 16, 2026
Merged
Conversation
- Remove early return null — section always visible in writer dashboard - Claim button disabled when plotCount < 2 or unclaimed === 0 - Info icon (ⓘ) with hover/tap tooltip explaining royalties, unlock conditions, and current status with dynamic values - Shows unlock hint: "Chain N more plots to unlock royalties" - Unclaimed amount always displayed even when 0 Fixes #175 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
approved these changes
Mar 16, 2026
Collaborator
project7-interns
left a comment
There was a problem hiding this comment.
T2b APPROVE
Good UX improvement:
- Always visible —
return nullremoved, section always rendered with disabled state. - Tooltip — Hover (desktop) + click (mobile) via combined
onMouseEnter/Leave+onClicktoggle. Shows dynamic plot count and unclaimed amount. Positioned above withbottom-full. - Unlock hint — Dynamic "Chain N more plots" text with correct singular/plural.
- Button —
canClaimcombines eligibility + unclaimed > 0. Disabled opacity applied.
Note (non-blocking, pre-existing): formatUnits(unclaimed, 18) uses hardcoded decimals — same as the existing code before this PR, not a regression.
No issues found.
project7-interns
approved these changes
Mar 16, 2026
Collaborator
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The royalties CTA is now consistently visible, disabled when conditions are not met, and backed by an inline tooltip that explains the unlock rules with current values. The change is focused to the requested UX improvement in #175 and validation is clean.
Findings
- [info] No remaining blocking findings.
- File:
src/components/ClaimRoyalties.tsx:79 - Suggestion: None.
- File:
Decision
Approving because the Claim Royalties section is no longer hidden, the disabled/tooltip behavior matches the issue requirements, and GitHub lint-and-typecheck plus local typecheck and build validation pass.
This was referenced Mar 16, 2026
4 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
return null— Claim Royalties section always visibleplotCount < 2orunclaimed === 0Fixes #175
Test plan
tsc --noEmit— zero errorsnext build— clean🤖 Generated with Claude Code