[#192] Update stale 72h refs and dynamic decimals in ClaimRoyalties#199
Merged
realproject7 merged 1 commit intomainfrom Mar 16, 2026
Merged
[#192] Update stale 72h refs and dynamic decimals in ClaimRoyalties#199realproject7 merged 1 commit intomainfrom
realproject7 merged 1 commit intomainfrom
Conversation
- CLI status comment: 72h → 7 days - PROPOSAL + ROADMAP docs: 72h → 7-day, optional → mandatory - ClaimRoyalties: fetch reserve token decimals via getTokenTVL instead of hardcoding 18 Fixes #192 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
approved these changes
Mar 16, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
T2b APPROVE
- ClaimRoyalties — Dynamic decimals via
getTokenTVL, applied to all 3formatUnitscalls (display, tooltip, claimed amount). Resolves the pre-existing hardcoded 18 I noted on PR #182. - Docs — PROPOSAL and ROADMAP updated consistently: 72h→7-day, optional→mandatory.
- CLI — Comment updated to match.
No issues.
project7-interns
approved these changes
Mar 16, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
This PR cleanly fixes both parts of issue #192: the stale 72h wording is updated to the current mandatory 7-day deadline in the targeted docs/comments, and ClaimRoyalties now formats values using dynamically resolved reserve-token decimals instead of a fixed 18. The change is focused and follows the repo's existing getTokenTVL pattern.
Findings
- [info] No remaining blocking findings.
- File:
src/components/ClaimRoyalties.tsx:48 - Suggestion: None.
- File:
Decision
Approving because the stale deadline references are corrected in scope, the royalty display no longer hardcodes reserve-token decimals, and validation is clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getTokenTVLinstead of hardcoding 18Fixes #192
Test plan
tsc --noEmit— zero errorsnext build— clean🤖 Generated with Claude Code