Unknown type "Upload" after latest update

[mijgame]

Hello,

Is it possible that #126 broke the default Upload type in existing implementations?
File uploads were working fine until the update. When I try to upload now, I get the Unkown type 'Upload" error back from the server.

I see that you can provide a name to the UploadType constructor, but it defaults to 'Upload'. Is it possible the '_upload' suffix is creating problems? I have tried different names in my query, but that doesn't change anything.

For completeness my Mutation and GraphQL query:

namespace App\GraphQL\Mutation;

use App\Classes\User\Tier;
use App\Verification;
use GraphQL\Type\Definition\ResolveInfo;
use GraphQL\Type\Definition\Type;
use Illuminate\Validation\Rule;
use Rebing\GraphQL\Support\Mutation;
use Rebing\GraphQL\Support\SelectFields;
use Rebing\GraphQL\Support\UploadType;
use GraphQL;

class AddImageToVerification extends Mutation
{
    protected $attributes = [
        'name' => 'addImageToVerification',
    ];

    /**
     * The allowed field names for
     * images that are added to the verification.
     *
     * @var array
     */
    protected $allowedFields = [
        'passport', 'selfie', 'address'
    ];

    public function type()
    {
        return GraphQL::type('Verification');
    }

    public function args()
    {
        return [
            'id' => [
                'name' => 'id',
                'type' => Type::int(),
                'rules' => [
                    'required',  'exists:verifications'
                ]
            ],
            'field' => [
                'name' => 'field',
                'type' => Type::string(),
                'rules' => [
                    'required',
                    'string',
                    Rule::in($this->allowedFields)
                ]
            ],
            'file' => [
                'name' => 'file',
                'type' => new UploadType(),
                'rules' => [
                    'required', 'image',  'max:8096'
                ]
            ]
        ];
    }

    public function resolve($root, $args, SelectFields $fields, ResolveInfo $info)
    {
        // Omitted
    }
}

 mutation addImage($id: Int!, $field: String!, $file: Upload!) {
        add_image_to_verification(id: $id, field: $field, file: $file) {
            id
        }
    }

Thanks in advance.

[rebing]

6024bb1
I removed the _upload suffix and it should work without specifying a name for the UploadType now. However I think it's still better if you use a custom name (i.e new UploadType('VerificationUpload') for the Upload type. This way you can have multiple UploadTypes in your schema.

[mijgame]

Thank you, that solved the problem. I agree that it is better, as I have run into this before and solved it using multiple calls and some code to resolve to the correct field. How would I address this type in my query? VerificationUpload! instead of Upload!? If that is the case, it would be handy to add it to the documentation since the type Upload is used everywhere on the web.

[rebing]

Yes, you have to use the custom name in the query, just as with EnumTypes for example. I'm sure it's somehow possible to modify this package so that the UploadType can be instantiated only once per schema, but I don't unfortunately have time to figure it out.