Updated PaginationType to allow custom fields to be injected #118
+106
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebing
requested changes
Aug 7, 2018
Owner
rebing
left a comment
rebing
left a comment
There was a problem hiding this comment.
Sorry for the delay, I'm on holiday. Looks good, but could you also please add or update the example in the documentation.
Contributor
Author
|
Thanks for replying - hope you're having a good holiday! I've made a couple of tweaks to the variable names to make things a little clearer and added in some documentation to explain how it works. Let me know if you want me to add/clarify anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slight git mix-up - I intended to push this into a fork of the repo before pushing across here! Anyway, is this something you might be interested in merging in? It's been useful for our project as we have some top-level metadata that needs to be merged into a paginated set of results, and this seemed to be a good way to acheive that.
Cheers, and apologies for wading in with a PR before raising an issue....