Skip to content

[DowngradePhp80] Handle combine DowngradeMixedTypeDeclarationRector+DowngradeAttributeToAnnotationRector on declare(strict_types=1) inline after open php tag#373

Merged
samsonasik merged 6 commits into
mainfrom
handle-mix
May 12, 2026
Merged

[DowngradePhp80] Handle combine DowngradeMixedTypeDeclarationRector+DowngradeAttributeToAnnotationRector on declare(strict_types=1) inline after open php tag#373
samsonasik merged 6 commits into
mainfrom
handle-mix

Conversation

@samsonasik
Copy link
Copy Markdown
Member

@samsonasik samsonasik commented May 12, 2026

Fixes rectorphp/rector#9759

It cause added new line before inline <?php declare(strict_types=1); just after open tag:

Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
+
 <?php declare(strict_types=1);

…owngradeAttributeToAnnotationRector on declare(strict_types=1) inline after open php tag
@samsonasik
Copy link
Copy Markdown
Member Author

Fixed 🎉 /cc @TomasVotruba

@samsonasik
Copy link
Copy Markdown
Member Author

All green 🎉 let's merge to have faster feedback to test ;)

@samsonasik samsonasik merged commit 364fbdb into main May 12, 2026
8 checks passed
@samsonasik samsonasik deleted the handle-mix branch May 12, 2026 10:53
@TomasVotruba
Copy link
Copy Markdown
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

rector-downgrade-php cause invalid printing on nette/utils 4.1.4

2 participants