Add ReplaceTestFunctionPrefixWithAttributeRector#386
Merged
samsonasik merged 3 commits intorectorphp:mainfrom Oct 30, 2024
Merged
Add ReplaceTestFunctionPrefixWithAttributeRector#386samsonasik merged 3 commits intorectorphp:mainfrom
samsonasik merged 3 commits intorectorphp:mainfrom
Conversation
Member
|
Awesome 👍😎 thanks for pushing this rule |
samsonasik
reviewed
Oct 27, 2024
rules/CodeQuality/Rector/ClassMethod/ReplaceTestFunctionPrefixWithAttributeRector.php
Show resolved
Hide resolved
Contributor
Author
|
I've fixed the rector failure manually since the action seems to have failed |
samsonasik
reviewed
Oct 30, 2024
rules/CodeQuality/Rector/ClassMethod/ReplaceTestFunctionPrefixWithAttributeRector.php
Outdated
Show resolved
Hide resolved
…WithAttributeRector.php
samsonasik
approved these changes
Oct 30, 2024
Member
|
Thank you @blackwolf12333 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a project with lots of phpunit tests that were defined using just the
testprefix on the function name. We'd like to move these to using the#[Test]attribute.Since we probably aren't the only people with this setup we thought we'd contribute it back :)