[DowngradePhp81] Follow parent return type on DowngradeNeverTypeDeclarationRector#1395
Merged
TomasVotruba merged 13 commits intomainfrom Dec 5, 2021
Merged
[DowngradePhp81] Follow parent return type on DowngradeNeverTypeDeclarationRector#1395TomasVotruba merged 13 commits intomainfrom
TomasVotruba merged 13 commits intomainfrom
Conversation
5e23258 to
61ee467
Compare
Member
Author
|
Fixed 🎉 |
ec81e1f to
cd2d6c2
Compare
cf80fd7 to
661f19a
Compare
e37cb70 to
4430ed8
Compare
4544a47 to
0a0a655
Compare
Member
Author
|
All checks have passed 🎉 @TomasVotruba it is ready for review. |
TomasVotruba
approved these changes
Dec 5, 2021
Member
|
Thank you |
Member
Author
|
It seems cause error on rector/rector repo: Run php bin/rector list --ansi
Rector 96cf57b15bbc4e3b9d5f2f4b58820460c7de448e
Usage:
command [options] [arguments]
PHP Fatal error: Declaration of RectorPrefix20211205\Symfony\Component\String\UnicodeString::join($strings, $lastGlue = NULL): RectorPrefix20211205\Symfony\Component\String\UnicodeString must be compatible with RectorPrefix20211205\Symfony\Component\String\AbstractUnicodeString::join($strings, $lastGlue = NULL): RectorPrefix20211205\Symfony\Component\String\AbstractUnicodeString in /home/runner/work/rector/rector/vendor/symfony/string/UnicodeString.php on line 31
Fatal error: Declaration of RectorPrefix20211205\Symfony\Component\String\UnicodeString::join($strings, $lastGlue = NULL): RectorPrefix20211205\Symfony\Component\String\UnicodeString must be compatible with RectorPrefix20211205\Symfony\Component\String\AbstractUnicodeString::join($strings, $lastGlue = NULL): RectorPrefix20211205\Symfony\Component\String\AbstractUnicodeString in /home/runner/work/rector/rector/vendor/symfony/string/UnicodeString.php on line 31https://github.com/rectorphp/rector/runs/4422515810?check_suite_focus=true#step:5:9 I will check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continue of #1390, when the class method implements interface method already has never type, eg:
above code in php 8.1 is valid ref https://3v4l.org/npms1#v8.1rc3.
But when it downgraded, it currently produce to:
which will make Fatal error:
ref https://3v4l.org/aZ2cq#v8.1rc3
This PR try to fix it.