Skip to content

[Transform] Remove ArgumentFuncCallToMethodCallRector as never used#3774

Merged
TomasVotruba merged 1 commit intomainfrom
tv-cleanup
May 8, 2023
Merged

[Transform] Remove ArgumentFuncCallToMethodCallRector as never used#3774
TomasVotruba merged 1 commit intomainfrom
tv-cleanup

Conversation

@TomasVotruba
Copy link
Copy Markdown
Member

@TomasVotruba TomasVotruba commented May 8, 2023

I recall I added this rule for Laravel "functions to facades" article many years ago as a demo for Rector features.
In the end its hardly practical and never used in any communityset. Let's see if this assumption is true :)

@TomasVotruba TomasVotruba merged commit 1877016 into main May 8, 2023
@TomasVotruba TomasVotruba deleted the tv-cleanup branch May 8, 2023 20:33
@samsonasik
Copy link
Copy Markdown
Member

@yguedidi
Copy link
Copy Markdown
Contributor

yguedidi commented May 9, 2023

@TomasVotruba just curious, isn't the removal of a rule a BC break? as it may be used by end user configurations I think

@TomasVotruba
Copy link
Copy Markdown
Member Author

@samsonasik I see. In that case should be ported there as better meets Laravel specific needs.

@driftingly Could you handle the copy of the rule?

@TomasVotruba
Copy link
Copy Markdown
Member Author

@yguedidi It could be so, that's what we try to find out.

@driftingly
Copy link
Copy Markdown

Done in driftingly/rector-laravel#108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants