[FileProcessor] Add warning instead of skip InlineHTML on PhpFileProcessor

[samsonasik]

Ref #4055 (review)

Instead of skip, better to show warning so user can just use it but need to verify manually the rectored file.

[samsonasik]

I removed with inline html fixture as SymfonyStyle warning seems not shown in unit test.

[samsonasik]

All checks have passed 🎉 @TomasVotruba it is ready for review.

[samsonasik]

@TomasVotruba here the output with warning instead of skip which fine on indirect change near InlineHTML:

➜  rector-src git:(add-warning) ✗ bin/rector process vendor/tracy/tracy/src/Tracy/BlueScreen/assets/section-stack-callStack.phtml --config build/config/config-downgrade.php --dry-run
 0/1 [░░░░░░░░░░░░░░░░░░░░░░░░░░░░]   0%
 [WARNING] File vendor/tracy/tracy/src/Tracy/BlueScreen/assets/section-stack-callStack.phtml has InlineHTML node, this  
           may cause unexpected output, you may need to manually verify the changed file                                

 1/1 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
1 file with changes
===================

1) vendor/tracy/tracy/src/Tracy/BlueScreen/assets/section-stack-callStack.phtml:71

    ---------- begin diff ----------
@@ @@
                        try {
                                $r = isset($row['class']) ? new \ReflectionMethod($row['class'], $row['function']) : new \ReflectionFunction($row['function']);
                                $params = $r->getParameters();
-                       } catch (\Exception) {
+                       } catch (\Exception $exception) {
                                $params = [];
                        }
                        foreach ($row['args'] as $k => $v) {
    ----------- end diff -----------

Applied rules:
 * DowngradeNonCapturingCatchesRector (https://wiki.php.net/rfc/non-capturing_catches)

so this should good to have it processed 👍

[Ocramius]

Good idea to leave mixed HTML+PHP alone, but some more verification (test) would be a good idea 😁

[kenjis]

It seems better to support mixed HTML+PHP even if there are limitations.

[samsonasik]

@Ocramius the tests were on MixedPhpHtmlDecorator, since that decorator removed at PR:

• [PHP+HTML cleanup] Remove MixPhpHtmlDecorator #4054

so the tests not needed in here

[samsonasik]

I enabled php-linter for tracy PHP+HTML file to be checked after downgrade for verifying on scoped build that the file still downgraded correctly 👍 e88a3c6 + d24dc9f

[TomasVotruba]

Looks good, lets give it a try 👍

If the feedback is rather breaking code again, we'll disable it to avoid causing errors.