Skip to content

[CodeQuality] Handle throw after if on ConsecutiveNullCompareReturnsToNullCoalesceQueueRector#4107

Merged
samsonasik merged 9 commits intomainfrom
throw-after-if
Jun 7, 2023
Merged

[CodeQuality] Handle throw after if on ConsecutiveNullCompareReturnsToNullCoalesceQueueRector#4107
samsonasik merged 9 commits intomainfrom
throw-after-if

Conversation

@samsonasik
Copy link
Copy Markdown
Member

@samsonasik samsonasik commented Jun 7, 2023 •
edited
Loading

@samsonasik samsonasik requested a review from TomasVotruba as a code owner June 7, 2023 13:42
@samsonasik
Copy link
Copy Markdown
Member Author

samsonasik commented Jun 7, 2023

Fixed 🎉 /cc @jlherren

@samsonasik samsonasik changed the title [CodeQuality] Handle throw after if on ConsecutiveNullCompareReturnsToNullCoalesceQueueRector [CodeQuality] Skip throw after if on ConsecutiveNullCompareReturnsToNullCoalesceQueueRector Jun 7, 2023
@samsonasik samsonasik changed the title [CodeQuality] Skip throw after if on ConsecutiveNullCompareReturnsToNullCoalesceQueueRector [CodeQuality] Handle throw after if on ConsecutiveNullCompareReturnsToNullCoalesceQueueRector Jun 7, 2023
@samsonasik
Copy link
Copy Markdown
Member Author

samsonasik commented Jun 7, 2023

All checks have passed 🎉 @TomasVotruba I think it is ready.

@samsonasik
Copy link
Copy Markdown
Member Author

samsonasik commented Jun 7, 2023

@TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 63816c0 into main Jun 7, 2023
@samsonasik samsonasik deleted the throw-after-if branch June 7, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect behavior of ConsecutiveNullCompareReturnsToNullCoalesceQueueRector

2 participants

@samsonasik @actions-user