Skip to content

StringClassNameToClassConstantRector: cheap checks first #4151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 1 commit into from
Jun 10, 2023
Merged

StringClassNameToClassConstantRector: cheap checks first #4151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions rules/Php55/Rector/String_/StringClassNameToClassConstantRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,10 +146,6 @@ public function provideMinPhpVersion(): int

private function shouldSkip(string $classLikeName): bool
{
if (! $this->reflectionProvider->hasClass($classLikeName)) {
return true;
}

// skip short class names, mostly invalid use of strings
if (! str_contains($classLikeName, '\\')) {
return true;
Expand All @@ -160,6 +156,10 @@ private function shouldSkip(string $classLikeName): bool
return true;
}

if (! $this->reflectionProvider->hasClass($classLikeName)) {
return true;
}

foreach ($this->classesToSkip as $classToSkip) {
if ($this->nodeNameResolver->isStringName($classLikeName, $classToSkip)) {
return true;
Expand Down