Remove BetterNodeFinder::findLastInstanceOf() as unused + make resolvePreviousNode() private, as used only locally#4195
Merged
TomasVotruba merged 2 commits intomainfrom Jun 12, 2023
Merged
Conversation
Member
TomasVotruba
commented
Jun 12, 2023
TomasVotruba
commented
- remove BetterNodeFinder::findLastInstanceOf() as unused
- make resolvePreviousNode() private, as used only locally
TomasVotruba
changed the title
Closed
samsonasik
reviewed
Jun 12, 2023
Member
samsonasik
left a comment
samsonasik
left a comment
There was a problem hiding this comment.
How about mark as @internal instead of making it private? It has @api which should be public.
Member
Author
|
I've refactored the only use in Symfony to local use. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.