Skip to content

[DeadCode] Skip non typed param numeric check on RecastingRemovalRector#4390

Merged
samsonasik merged 5 commits intomainfrom
skip-non-typed-numeric
Jul 1, 2023
Merged

[DeadCode] Skip non typed param numeric check on RecastingRemovalRector#4390
samsonasik merged 5 commits intomainfrom
skip-non-typed-numeric

Conversation

@samsonasik
Copy link
Copy Markdown
Member

@samsonasik samsonasik requested a review from TomasVotruba as a code owner July 1, 2023 10:28
@samsonasik
Copy link
Copy Markdown
Member Author

let's try with equal check if not mixed 5a2a1cf

@samsonasik
Copy link
Copy Markdown
Member Author

still error, let's give a try with super type check e6f4124

@samsonasik samsonasik enabled auto-merge (squash) July 1, 2023 10:44
@samsonasik samsonasik merged commit 2161084 into main Jul 1, 2023
@samsonasik samsonasik deleted the skip-non-typed-numeric branch July 1, 2023 10:45
@samsonasik
Copy link
Copy Markdown
Member Author

samsonasik commented Jul 1, 2023

@TomasVotruba fixed ;), I am merging it ;)

@staabm I may need your help to verify this in other projects usage ;), the change was from removing parent lookup on #4389 which cause issue on is_numeric() check against (int) cast so need to verify type equality on Union type. Thank you ;)

@staabm
Copy link
Copy Markdown
Contributor

staabm commented Jul 2, 2023

I may need your help to verify this in other projects usage

could you get more precise how I can help you?

@samsonasik
Copy link
Copy Markdown
Member Author

@staabm that's what you tried on #4380 (comment) , it seems working ok 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants