[DeadCode] Skip non typed param numeric check on RecastingRemovalRector#4390
Merged
samsonasik merged 5 commits intomainfrom Jul 1, 2023
Merged
[DeadCode] Skip non typed param numeric check on RecastingRemovalRector#4390samsonasik merged 5 commits intomainfrom
samsonasik merged 5 commits intomainfrom
Conversation
Member
Author
|
let's try with equal check if not mixed 5a2a1cf |
Member
Author
|
still error, let's give a try with super type check e6f4124 |
Member
Author
|
@TomasVotruba fixed ;), I am merging it ;) @staabm I may need your help to verify this in other projects usage ;), the change was from removing parent lookup on #4389 which cause issue on |
Contributor
could you get more precise how I can help you? |
Member
Author
|
@staabm that's what you tried on #4380 (comment) , it seems working ok 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #4389 (comment)