[NodeAnalyzer] Remove parent attribute on ScopeAnalyzer

[samsonasik]

No description provided.

[samsonasik]

All checks have passed 🎉 @TomasVotruba I am merging it to have faster feedback to test ;)

[samsonasik]

Tested on CodeIgniter4 project, now got error:

➜  CodeIgniter4 git:(develop) ✗ time vendor/bin/rector 
 603/790 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓░░░░░░░]  76%
                                                                                
 [ERROR] Could not process                                                      
         "/home/abdul/www/CodeIgniter4/system/CLI/Commands.php" file, due to:   
         "System error: "Scope not available on                                 
         "PhpParser\Node\Name\FullyQualified" node with parent node of          
         "PhpParser\Node\Stmt\Catch_", but is required by a refactorWithScope() 
         method of "Rector\Renaming\Rector\Name\RenameClassRector" rule. Fix    
         scope refresh on changed nodes first"                                  
         Run Rector with "--debug" option and post the report here: https://github.com/rectorphp/rector/issues/new". On line:
         53                                                                     

I will check check it.

[samsonasik]

#4401

[staabm]

My unverified guess:

I think Scope instances are way heavier in memory than Ast-Nodes. This would mean that this patch might even worse memory use, as we are trading references to Ast Nodes with references to Scope objects.

After getting rid of the parent-AST-attribute we need to check these Scope attribute, as it is used so often. Maybe we can make use of WeakReference

[samsonasik]

@staabm it maybe due to stack nodes on ParentConnectingVisitor, I create an RFC for that, see rectorphp/rector#8035

[samsonasik]

@staabm I will check if this can be reduced by using $mutatingScope->enterXYZ() method to fill inside instead of manually fill it, as it may goes out of control.

[samsonasik]

@TomasVotruba @staabm I am checking PHPStan source, and it seems NodeScopeResolver->processNodes() is called internally at FileAnalyser::analyseFile()

https://github.com/phpstan/phpstan-src/blob/762c8148ac9a6a66d3a513cbc52e5be1c2d75331/src/Analyser/FileAnalyser.php#L176

I am wondering if we can just use that method instead of manually fill the Scope in every use finding cases, I will lookup if that possible.

[staabm]

I don't know enough about the inner workings of rector to answer that question.

[samsonasik]

@staabm if we can get rid of "scope" attribute, and get the scope from its PHPStan node scope context, that probably will be a real solution.

PHPStan has "Virtual" node, that probably a way to resolve Scope from that.

[samsonasik]

@TomasVotruba @staabm the most scope filling here is for RenameClassRector which tries to get scope from Name node, I will try if there is a way to refactor RenameClassRector to use its ClassLike or TraitUse or Use_ instead of direct Name node, so Scope filling will be unneeded for name, as Name scope itself is "unrefreshable", see

rector-src/src/Application/ChangedNodeScopeRefresher.php

Lines 130 to 139 in 77b0bb7

	if ($node instanceof Stmt) {
	return [$node];
	}
	if ($node instanceof Expr) {
	return [new Expression($node)];
	}
	$errorMessage = sprintf('Complete parent node of "%s" be a stmt.', $node::class);
	throw new ShouldNotHappenException($errorMessage);

[samsonasik]

@staabm @TomasVotruba I created PR #4422 for it.