Deprecate resolveNextNode() to work only in current node tree context#4455
Merged
TomasVotruba merged 2 commits intomainfrom Jul 9, 2023
Merged
Deprecate resolveNextNode() to work only in current node tree context#4455TomasVotruba merged 2 commits intomainfrom
TomasVotruba merged 2 commits intomainfrom
Conversation
TomasVotruba
changed the title
samsonasik
reviewed
Jul 9, 2023
| if ($node instanceof Variable) { | ||
| $concat->right->value .= '.'; | ||
| } | ||
| $concat->right->value .= '.'; |
Member
There was a problem hiding this comment.
on original solution, it using Token based check, I will update it.
Member
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
Looks good. I wonder why no test is failing here though 🤔
Let's go with current version in this PR untill we find the breaking code, so we have it covered in test fixture for sure.
Member
There was a problem hiding this comment.
yes, it definitelly breaking change, as we limit to variable on purpose to avoid next is func call, but let's see how large it break
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.