Skip to content

[DX] Remove parent node from AbstractRector#4465

Merged
samsonasik merged 16 commits intomainfrom
tv-remove-parent-node-from-abstract-rector-take-2
Jul 9, 2023
Merged

[DX] Remove parent node from AbstractRector#4465
samsonasik merged 16 commits intomainfrom
tv-remove-parent-node-from-abstract-rector-take-2

Conversation

@TomasVotruba
Copy link
Copy Markdown
Member

@TomasVotruba TomasVotruba commented Jul 9, 2023

No description provided.

@TomasVotruba TomasVotruba force-pushed the tv-remove-parent-node-from-abstract-rector-take-2 branch 2 times, most recently from 53a7bac to 57995ac Compare July 9, 2023 16:59
@TomasVotruba TomasVotruba changed the title tv remove parent node from abstract rector take 2 [WIP] tv remove parent node from abstract rector take 2 Jul 9, 2023
@TomasVotruba TomasVotruba force-pushed the tv-remove-parent-node-from-abstract-rector-take-2 branch 3 times, most recently from deb9e40 to a185bd8 Compare July 9, 2023 17:10
@samsonasik
Copy link
Copy Markdown
Member

RunTestsInSeparateProcesses may need to be used in RenameClasaRector tests

@TomasVotruba TomasVotruba force-pushed the tv-remove-parent-node-from-abstract-rector-take-2 branch from 57a1cbb to 9a0d7b3 Compare July 9, 2023 17:32
@samsonasik
Copy link
Copy Markdown
Member

AutoImportNamesTest need RunTestsInSeparateProcesses as well

@TomasVotruba TomasVotruba force-pushed the tv-remove-parent-node-from-abstract-rector-take-2 branch from 81afedc to 873664c Compare July 9, 2023 17:43
@samsonasik
Copy link
Copy Markdown
Member

Rename fixture usually solve it, but that will take try and errors, apply the RunTestsInSeparateProcesses into test classes is the fastest way to go, on this case, AutoImportNamesTest seems need to be updated as well

@TomasVotruba TomasVotruba force-pushed the tv-remove-parent-node-from-abstract-rector-take-2 branch 4 times, most recently from 0d51357 to 2f9cf4c Compare July 9, 2023 18:04
@TomasVotruba TomasVotruba force-pushed the tv-remove-parent-node-from-abstract-rector-take-2 branch from 2f9cf4c to 2749b82 Compare July 9, 2023 18:05
@TomasVotruba TomasVotruba changed the title [WIP] tv remove parent node from abstract rector take 2 [WIP] Remove parent node from AbstractRector Jul 9, 2023
@TomasVotruba TomasVotruba force-pushed the tv-remove-parent-node-from-abstract-rector-take-2 branch from 35f7139 to 71f1753 Compare July 9, 2023 18:08
@TomasVotruba TomasVotruba changed the title [WIP] Remove parent node from AbstractRector [DX] Remove parent node from AbstractRector Jul 9, 2023
@TomasVotruba TomasVotruba requested a review from samsonasik July 9, 2023 18:11
@samsonasik
Copy link
Copy Markdown
Member

The removed fixtures should be rolled back to ensure no behaviour changed, I will check

@TomasVotruba TomasVotruba force-pushed the tv-remove-parent-node-from-abstract-rector-take-2 branch from afe9bbc to 74c9a87 Compare July 9, 2023 18:19
@samsonasik
Copy link
Copy Markdown
Member

I rolled back removed fixtures 3b43f59

@TomasVotruba TomasVotruba force-pushed the tv-remove-parent-node-from-abstract-rector-take-2 branch from 3b43f59 to e08545f Compare July 9, 2023 18:21
@TomasVotruba
Copy link
Copy Markdown
Member Author

TomasVotruba commented Jul 9, 2023

@samsonasik Gotta go dinner now :). Feel free to merge when this is ready 🙏

We can test in the wild 💪

@samsonasik
Copy link
Copy Markdown
Member

All checks have passed 🎉 @TomasVotruba let's merge it ;)

@samsonasik samsonasik merged commit 868612a into main Jul 9, 2023
@samsonasik samsonasik deleted the tv-remove-parent-node-from-abstract-rector-take-2 branch July 9, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants