[CodeQuality][EarlyReturn] Handle crash Replace Stmt to Expr on FlipTypeControlToUseExclusiveTypeRector+FlipTypeControlToUseExclusiveTypeRector+ReturnBinaryOrToEarlyReturnRector

[samsonasik]

Fixes rectorphp/rector#8044

[TomasVotruba]

Thanks for the test fixture 👍

Seems the fix commit is missing. Or still WIP? :)

[samsonasik]

I am still looking for the solution 👍

[TomasVotruba]

I can check if you want. It will be some rule returning expr instead of stmt. Not directly in the refactor() method, but in one of nested nodes IMO.

[samsonasik]

That seems due to refactor return array of nodes, which inside the nodes doesn't have origNode yet/overlapped on multi rules

[samsonasik]

It seems can be tweaked on RectifiedAnalyzer, wait a minute ...

[TomasVotruba]

That seems due to refactor return array of nodes, which inside the nodes doesn't have origNode yet/overlapped on multi rules

That should be ok, untill all those arrays contain only stmts.

[samsonasik]

Fixed with verify on re-print has empty origNode, that's means the node is on nested Expr d0e6a73

[samsonasik]

All checks have passed 🎉 @TomasVotruba let's give it a try to have faster feedback to test ;)

[samsonasik]

It seems cause error on downgrade:

------------------------------------------------------------
Parse error: rector-prefixed-downgraded/packages/BetterPhpDocParser/PhpDocParser/BetterPhpDocParser.php:55
    53|     public function __construct(TypeParser $typeParser, ConstExprParser $constExprParser, CurrentNodeProvider $currentNodeProvider, TokenIteratorFactory $tokenIteratorFactory, iterable $phpDocNodeDecorators, PrivatesAccessor $privatesAccessor = null)
    54|     {
  > 55|         $privatesAccessor ??= new PrivatesAccessor();
    56|         $this->currentNodeProvider = $currentNodeProvider;
    57|         $this->tokenIteratorFactory = $tokenIteratorFactory;
Unexpected '=' in rector-prefixed-downgraded/packages/BetterPhpDocParser/PhpDocParser/BetterPhpDocParser.php on line 55
------------------------------------------------------------
Parse error: rector-prefixed-downgraded/vendor/rector/rector-doctrine/src/NodeManipulator/ColumnPropertyTypeResolver.php:59
    57|     public function __construct(PhpDocInfoFactory $phpDocInfoFactory, TypeFactory $typeFactory, AttributeFinder $attributeFinder, array $doctrineTypeToScalarType = null)
    58|     {
  > 59|         $doctrineTypeToScalarType ??= [
    60|             'tinyint' => new BooleanType(),
    61|             'boolean' => new BooleanType(),
Unexpected '=' in rector-prefixed-downgraded/vendor/rector/rector-doctrine/src/NodeManipulator/ColumnPropertyTypeResolver.php on line 59

https://github.com/rectorphp/rector-src/actions/runs/5518361429/jobs/10062204998#step:15:23

I will check 👍

[canvural]

Thank you @samsonasik 🎉

BTW I also get a similar error Trying to replace statement (Stmt_If) with expression (Expr_Instanceof). Are you missing a Stmt_Expression wrapper?

But I could not reproduce this one in the playground. Just writing it here in case it rings a bell for you. Or maybe it'll also be fixed with this PR because both are Stmt

[samsonasik]

@canvural yes, that should be resolved in core instead of individual rule to avoid similar issue happen again.

I am looking into it, as current solution cause error on downgrade

[TomasVotruba]

I'll tag a new version 👍

[samsonasik]

@TomasVotruba it not yet resolved, so new tag won't be applied to downgrade as downgrade build error

[TomasVotruba]

Ah, I see :)