[CodeQuality] Skip fluent call from FuncCall crash on OptionalParametersAfterRequiredRector

[samsonasik]

Fixes rectorphp/rector#8063
Ref https://getrector.com/demo/576513b9-85eb-48d8-88db-1e3507857c19

[samsonasik]

@Kauto this should fix rectorphp/rector#8063, I tried in getrector.org server :)

[samsonasik]

@TomasVotruba the following use case need to be covered 8009b39

final class UpdateMethodCallByFluent
{
    public function run($optional = 1, $required)
    {
        return $this;
    }

    public function execute()
    {
    }

    public function process()
    {
        $this->run(1, 5)
             ->execute();
    }
}

The original functionality actually not working yet for above case even the hack reverted.

[samsonasik]

@TomasVotruba it seems actually working on proper fluent call return $this

af5c351

👍

[samsonasik]

The buggy part will be on second part as fluent:

final class UpdateMethodCallByFluent2
{
    public function execute()
    {
        return $this;
    }

    public function run($optional = 1, $required)
    {
        return $this;
    }

    public function process()
    {
        $this->execute()
             ->run(1, 5);
    }
}

[samsonasik]

Really unsure how to cover this, some process probably overlapped when tested in server

https://getrector.com/demo/576513b9-85eb-48d8-88db-1e3507857c19

@TomasVotruba probably the best way is to extends PHPStan printer ?

[TomasVotruba]

Really unsure how to cover this, some process probably overlapped when tested in server

It might need some cache clearing, e.g. /tmp/rector and /tmp/phpstan

[samsonasik]

@TomasVotruba I tried that, not working, the issue is happen only on fluent call:

• fluent call (crash) https://getrector.com/demo/a8587d19-4108-4db8-ac90-fc80afae71ec
• non-fluent call (working ok) https://getrector.com/demo/dd9e789f-ce8d-4c33-962e-5e03f63c6165

[samsonasik]

Closing as resolved at PR:

• [Printer] Fix printing PHPStan AlwaysRememberedExpr with add unwrapper inside BetterStandardPrinter::p #4629