Skip to content

[Performance][PostRector] Remove alias exists check on NameImporter called from NameImportingPostRector#4564

Merged
samsonasik merged 6 commits intomainfrom
remove-alias-check
Jul 21, 2023
Merged

[Performance][PostRector] Remove alias exists check on NameImporter called from NameImportingPostRector#4564
samsonasik merged 6 commits intomainfrom
remove-alias-check

Conversation

@samsonasik
Copy link
Copy Markdown
Member

@samsonasik samsonasik commented Jul 21, 2023

@TomasVotruba @staabm the alias exists check already in NameImportingPostRector before NameImporter->importName() called

$aliasName = $this->aliasNameResolver->resolveByName($name);
if (is_string($aliasName)) {
return new Name($aliasName);
}

, so I think it no longer needed.

Ref rectorphp/rector#8077

@samsonasik samsonasik requested a review from TomasVotruba as a code owner July 21, 2023 08:27
@samsonasik
Copy link
Copy Markdown
Member Author

All checks have passed 🎉 @TomasVotruba let's merge it to have faster feedback to test ;)

@samsonasik samsonasik merged commit 2faa19f into main Jul 21, 2023
@samsonasik samsonasik deleted the remove-alias-check branch July 21, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants