[TypeDeclaration] Add StrictStringParamConcatRector#4624
Merged
TomasVotruba merged 2 commits intomainfrom Jul 31, 2023
Merged
Conversation
staabm
reviewed
Jul 30, 2023
| $paramName, | ||
| &$isParamConcatted, | ||
| ): int|null { | ||
| if ($node instanceof Concat) { |
Contributor
There was a problem hiding this comment.
I think we need a separate case for Encapsed nodes
Member
Author
There was a problem hiding this comment.
Could you share a test fixture of what you mean?
samsonasik
reviewed
Jul 30, 2023
TomasVotruba
force-pushed
the
tv-concat-string-type
branch
6 times, most recently
from
08c5e9a to
0527974
Compare
TomasVotruba
force-pushed
the
tv-concat-string-type
branch
from
0527974 to
0cdda18
Compare
Member
|
I added fixture for inner function, see fixture https://github.com/rectorphp/rector-src/pull/4624/files#diff-61c954ee87cdbb294af4186e610a14183f116c61a5ad32d6c44c62e823e1d086 |
samsonasik
reviewed
Jul 31, 2023
samsonasik
reviewed
Jul 31, 2023
samsonasik
reviewed
Jul 31, 2023
TomasVotruba
force-pushed
the
tv-concat-string-type
branch
2 times, most recently
from
01fde8f to
f35f0a7
Compare
TomasVotruba
force-pushed
the
tv-concat-string-type
branch
from
f35f0a7 to
f58c785
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.