[PHPStanStaticTypeMapper] Handle crash on DowngradeMixedTypeDeclarationRector for PHPStan\Type\ConditionalType#4625
Merged
TomasVotruba merged 5 commits intomainfrom Jul 31, 2023
Merged
Conversation
…onRector for PHPStan\Type\ConditionalType
Member
Author
|
@TomasVotruba I added /**
* @template TValue of array<array|scalar>|scalar
*
- * @return (TValue is scalar ? array|scalar : array<array|scalar>)
+ * @return (Rector\Core\Tests\Issues\IssueConditionalType\Fixture\TValue is (bool | float | int | string) ? (array | bool | float | int | string) : array<(array | bool | float | int | string)>)
*/ |
samsonasik
commented
Jul 31, 2023
Comment on lines
+45
to
+52
| $type = TypeTraverser::map($type, static function (Type $type, callable $traverse): Type { | ||
| if ($type instanceof \PHPStan\Type\ObjectType && $type->getClassReflection() === null) { | ||
| $newClassName = Strings::after($type->getClassName(), '\\', -1); | ||
| $type = new \PHPStan\Type\ObjectType($newClassName); | ||
| } | ||
|
|
||
| return $traverse($type); | ||
| }); |
Member
Author
There was a problem hiding this comment.
@TomasVotruba this is to tweak the @template usage
Member
Author
|
@leoloso it fixed, with tweak, I am not sure if this will be an elegant solution, but just looking at the use case, it seems the way to resolve it. |
Member
Author
|
All checks have passed 🎉 @TomasVotruba it is ready for review. |
Member
|
Thanks 🙏 |
Contributor
|
@samsonasik it's working well, thanks! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#8099