[TypeDeclaration] Add nullable param from null compare on StrictStringParamConcatRector#4636
Merged
samsonasik merged 4 commits intomainfrom Aug 3, 2023
Merged
[TypeDeclaration] Add nullable param from null compare on StrictStringParamConcatRector#4636samsonasik merged 4 commits intomainfrom
samsonasik merged 4 commits intomainfrom
Conversation
…gParamConcatRector
Member
Author
|
Fixed 🎉 /cc @staabm |
Member
Author
|
All checks have passed 🎉 @TomasVotruba let's merge to have faster feedback to test ;) |
staabm
reviewed
Aug 3, 2023
| { | ||
| public static function getOrderBy($orderby, $direction = 'ASC', $default = '') | ||
| { | ||
| if (null !== $orderby && ! empty($orderby)) { |
Contributor
There was a problem hiding this comment.
will is_null() calls also be covered?
Member
Author
There was a problem hiding this comment.
Yes, I tried:
if (! is_null($orderby) && ! empty($orderby)) {
return $orderby.' '.$direction;
}and it also changed to nullable string ?string 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.