[TypeDeclaration] Remove AddClosureReturnTypeRector

[samsonasik]

@TomasVotruba @staabm the AddClosureReturnTypeRector use docblock from method caller as return type, which invalid.

I think this rule can be removed and use more specific return type rules instead.

see https://getrector.com/demo/d2f40f82-855f-4414-adb5-7ae99cfc7ce0

[samsonasik]

see https://getrector.com/demo/d2f40f82-855f-4414-adb5-7ae99cfc7ce0

[samsonasik]

All checks have passed 🎉 @TomasVotruba it is ready for review.

[staabm]

don't we have a ReturnType*FromStrict rule which works on the same cases but with a native return type?

if so, maybe some of the test-cases can be moved into that rule

[samsonasik]

ReturnTypeFromStrictTypedCallRector already cover that, here the test:

• with only docblock (skipped) https://getrector.com/demo/3df87ced-340d-4355-bfe5-cbd9750c6a82
• with return type (applied) https://getrector.com/demo/1ee6c000-5afe-4681-aef2-d4a3a0edf963

[samsonasik]

@staabm I added test case by docblock for ReturnTypeFromStrictTypedCallRector 7bf8ea1

[TomasVotruba]

Awesome cleanup 🎉 👍