Skip to content

[DX] Move FlipNegatedTernaryInstanceofRector to instanceof rules category #4663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 2 commits into from
Aug 5, 2023
Merged

[DX] Move FlipNegatedTernaryInstanceofRector to instanceof rules category #4663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bea1f8f
Move FlipNegatedTernaryInstanceofRector to instanceof rules set
TomasVotruba Aug 5, 2023
9404e86
add instanceof set to check missing-in-command
TomasVotruba Aug 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/set/instanceof.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@
use Rector\CodeQuality\Rector\Identical\GetClassToInstanceOfRector;
use Rector\Config\RectorConfig;
use Rector\DeadCode\Rector\If_\RemoveDeadInstanceOfRector;
use Rector\Instanceof_\Rector\Ternary\FlipNegatedTernaryInstanceofRector;
use Rector\TypeDeclaration\Rector\BooleanAnd\BinaryOpNullableToInstanceofRector;
use Rector\TypeDeclaration\Rector\Empty_\EmptyOnNullableObjectToInstanceOfRector;
use Rector\TypeDeclaration\Rector\Ternary\FlipNegatedTernaryInstanceofRector;
use Rector\TypeDeclaration\Rector\While_\WhileNullableToInstanceofRector;

return static function (RectorConfig $rectorConfig): void {
Expand Down
0 ...anceofRector/Fixture/skip_no_cond.php.inc → ...anceofRector/Fixture/skip_no_cond.php.inc
View file
Open in desktop
File renamed without changes.
0 ...stanceofRector/Fixture/some_class.php.inc → ...stanceofRector/Fixture/some_class.php.inc
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion ...lipNegatedTernaryInstanceofRectorTest.php → ...lipNegatedTernaryInstanceofRectorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

declare(strict_types=1);

namespace Rector\Tests\TypeDeclaration\Rector\Ternary\FlipNegatedTernaryInstanceofRector;
namespace Rector\Tests\Instanceof_\Rector\Ternary\FlipNegatedTernaryInstanceofRector;

use Iterator;
use PHPUnit\Framework\Attributes\DataProvider;
Expand Down
2 changes: 1 addition & 1 deletion ...stanceofRector/config/configured_rule.php → ...stanceofRector/config/configured_rule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

use Rector\Config\RectorConfig;

use Rector\TypeDeclaration\Rector\Ternary\FlipNegatedTernaryInstanceofRector;
use Rector\Instanceof_\Rector\Ternary\FlipNegatedTernaryInstanceofRector;

return static function (RectorConfig $rectorConfig): void {
$rectorConfig->rule(FlipNegatedTernaryInstanceofRector::class);
Expand Down
4 changes: 2 additions & 2 deletions ...ry/FlipNegatedTernaryInstanceofRector.php → ...ry/FlipNegatedTernaryInstanceofRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

declare(strict_types=1);

namespace Rector\TypeDeclaration\Rector\Ternary;
namespace Rector\Instanceof_\Rector\Ternary;

use PhpParser\Node;
use PhpParser\Node\Expr;
Expand All @@ -14,7 +14,7 @@
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;

/**
* @see \Rector\Tests\TypeDeclaration\Rector\Ternary\FlipNegatedTernaryInstanceofRector\FlipNegatedTernaryInstanceofRectorTest
* @see \Rector\Tests\Instanceof_\Rector\Ternary\FlipNegatedTernaryInstanceofRector\FlipNegatedTernaryInstanceofRectorTest
*/
final class FlipNegatedTernaryInstanceofRector extends AbstractRector
{
Expand Down
3 changes: 1 addition & 2 deletions utils/Command/MissingInSetCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
use Rector\Core\Contract\Rector\ConfigurableRectorInterface;
use Rector\TypeDeclaration\Rector\BooleanAnd\BinaryOpNullableToInstanceofRector;
use Rector\TypeDeclaration\Rector\StmtsAwareInterface\DeclareStrictTypesRector;
use Rector\TypeDeclaration\Rector\Ternary\FlipNegatedTernaryInstanceofRector;
use Rector\TypeDeclaration\Rector\While_\WhileNullableToInstanceofRector;
use Rector\Utils\Finder\RectorClassFinder;
use Rector\Utils\Finder\SetRectorClassesResolver;
Expand Down Expand Up @@ -45,6 +44,7 @@ final class MissingInSetCommand extends Command
__DIR__ . '/../../rules/Php81/Rector' => __DIR__ . '/../../config/set/php81.php',
__DIR__ . '/../../rules/Php82/Rector' => __DIR__ . '/../../config/set/php82.php',
__DIR__ . '/../../rules/Strict/Rector' => __DIR__ . '/../../config/set/strict-booleans.php',
__DIR__ . '/../../rules/Instanceof_/Rector' => __DIR__ . '/../../config/set/instanceof.php',

// doctrine
__DIR__ . '/../../vendor/rector/rector-doctrine/rules/CodeQuality' => __DIR__ . '/../../vendor/rector/rector-doctrine/config/sets/doctrine-code-quality.php',
Expand Down Expand Up @@ -94,7 +94,6 @@ final class MissingInSetCommand extends Command
DeclareStrictTypesRector::class,
// optional
DataProviderArrayItemsNewlinedRector::class,
FlipNegatedTernaryInstanceofRector::class,
BinaryOpNullableToInstanceofRector::class,
WhileNullableToInstanceofRector::class,
];
Expand Down