[TypeDeclaration] Skip non void or never already return typed on ReturnNeverTypeRector#4723
Merged
samsonasik merged 2 commits intomainfrom Aug 8, 2023
Merged
[TypeDeclaration] Skip non void or never already return typed on ReturnNeverTypeRector#4723samsonasik merged 2 commits intomainfrom
samsonasik merged 2 commits intomainfrom
Conversation
…rnNeverTypeRector
…rnNeverTypeRector
Member
Author
|
All checks have passed 🎉 @TomasVotruba I am merging it ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReturnNeverTypeRectorallow to changevoidtonever:https://getrector.com/demo/a1dc789f-5f71-49ab-a896-477e0365e055
so it detect the return data inside
FunctionLike, for other thanvoidorneverand already typed, eg:bool, I think no need to check insideFunctionLike, just skipped early.