[DX] Remove AddDefaultValueForUndefinedVariableRector as can generate broken code and depends on context#4729
Merged
TomasVotruba merged 2 commits intomainfrom Aug 9, 2023
Merged
Conversation
… broken code and depends on context
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rule can cause errors in case of added/new/removed variables, as it can think that just removed variable should be added :)
It can cause crashes like these: #4702 (comment)
There was ❗ 9 extra test that colided with other rules just to be sure it doesn't colide with each other. Still not good enough.
Also missing variable raises a warning, so not really deprecation: https://3v4l.org/nMR15
Better let PHPStan report it and fix propperly 👍