[DX] Avoid supporting edge-case multi-layered comments, must be covered in php-parser itself#4743
Merged
TomasVotruba merged 3 commits intomainfrom Aug 9, 2023
Merged
[DX] Avoid supporting edge-case multi-layered comments, must be covered in php-parser itself#4743TomasVotruba merged 3 commits intomainfrom
TomasVotruba merged 3 commits intomainfrom
Conversation
TomasVotruba
force-pushed
the
tv-simples-2
branch
3 times, most recently
from
8adbe92 to
9e96bc7
Compare
TomasVotruba
force-pushed
the
tv-simples-2
branch
from
9e96bc7 to
ffdb422
Compare
TomasVotruba
changed the title
Member
|
/cc @neveldo FYI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We cannot support these, as it's responsibility of php-parser that stores comments to the particular nodes. Should be handled first there.
Also, such comments seem like code smell and should be avoided.