[Renaming] Remove callables from class renames to avoid missed rename bugs, better handle with PHSPtan and custom rule#4745
Merged
TomasVotruba merged 1 commit intomainfrom Aug 9, 2023
Conversation
TomasVotruba
force-pushed
the
tv-remove-callable
branch
from
038ee0f to
24741b2
Compare
… bugs, better handle with PHSPtan and custom rule
TomasVotruba
force-pushed
the
tv-remove-callable
branch
from
5bdced8 to
5c3a263
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm thinking about this rule in retrospect and it seems it's crossing border with PHPStan and IDE fetaures.
While it might be benefitical for automated fixes of architecture standard, it's leaking feature of dynamic coding to the tool.
It doesn't seem useful to public nor standard sets. Instead these should be handled in a custom Rector rule or better required by PHPStan, as probably is already :)
I wan to keep IDE features and dynamic code sepeate, as we focus mainly on strict and clear no-brainer refactorings. Morover with upcoming GPT coding that goes the opposite way.
Saying that I'll withdraw this feature to keep Rector robuts and focuses.
Also, there might happen bug there class is rename, but it's usage is not, because it was already processed.