[TypeDeclaration] Do not add default value when assigned in __construct() on TypedPropertyFromStrictGetterMethodReturnTypeRector#4886
Merged
samsonasik merged 3 commits intomainfrom Aug 31, 2023
Merged
Conversation
…ct() on TypedPropertyFromStrictGetterMethodReturnTypeRector
Member
Author
|
Fixed 🎉 |
Member
Author
|
All checks have passed 🎉 @TomasVotruba I think it is ready. |
Member
Author
|
@TomasVotruba I am merging it ;) |
Member
|
Looks good 👍 I think the getter rule should skip these cases, as the constructor defines a property type here. What do you think? |
Member
Author
|
For direct single rule usage, the type still make sense, just don't add default value as always replaced early on __construct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@TomasVotruba continue of PR:
when initialized in
__construct(), default value should not be added.