[TypeDeclaration] Add nullable return $this on ReturnUnionTypeRector#4891
Closed
samsonasik wants to merge 7 commits intomainfrom
Closed
[TypeDeclaration] Add nullable return $this on ReturnUnionTypeRector#4891samsonasik wants to merge 7 commits intomainfrom
samsonasik wants to merge 7 commits intomainfrom
Conversation
samsonasik
changed the title
samsonasik
commented
Aug 31, 2023
Comment on lines
+64
to
+66
| if ($type instanceof ThisType) { | ||
| return new Name(ObjectReference::SELF); | ||
| } |
Member
Author
There was a problem hiding this comment.
@staabm this will make add self to return even on non-final class => ?self on use return $this, so it can downgrade the functionality.
I guess we need another "special fixer rule" to change "self" to "static" when possible (depends on php version)
so this change need more consideration :)
Member
Author
|
I am closing for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@staabm here for the nullable return new self on
ReturnUnionTypeRector