Add test case for caching $rectorConfig->rules() changed#4903
Merged
samsonasik merged 19 commits intomainfrom Sep 4, 2023
Merged
Add test case for caching $rectorConfig->rules() changed#4903samsonasik merged 19 commits intomainfrom
samsonasik merged 19 commits intomainfrom
Conversation
Member
Author
|
@TomasVotruba I debugged |
Member
Author
|
@TomasVotruba using |
Member
Author
|
@TomasVotruba @staabm I got test case working ok now, ready for merge 👍 |
samsonasik
changed the title
TomasVotruba
approved these changes
Sep 3, 2023
Member
TomasVotruba
left a comment
TomasVotruba
left a comment
There was a problem hiding this comment.
Thank you, go for merge when ready 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on your PR:
this is failing test case that rules should be changed the hash insteaf of equal