StrictArrayParamDimFetchRector: Skip objects#4907
Merged
samsonasik merged 3 commits intorectorphp:mainfrom Sep 4, 2023
Merged
Conversation
staabm
commented
Sep 4, 2023
| { | ||
| $item->doSomething(); | ||
|
|
||
| return $item['name']; |
Contributor
Author
There was a problem hiding this comment.
this might be a object which implements ArrayAccess and therefore has a array-dim-fetch
samsonasik
reviewed
Sep 4, 2023
| } | ||
|
|
||
| if ($nodeToCheck instanceof Node\Expr\MethodCall && $this->isName($nodeToCheck->var, $paramName)) { | ||
| return true; |
Member
There was a problem hiding this comment.
$nodeToCheck->var can be not variable, so better to check $nodeToCheck->var instanceof Node\Expr\Variable too
samsonasik
approved these changes
Sep 4, 2023
Member
samsonasik
left a comment
samsonasik
left a comment
There was a problem hiding this comment.
Lets give it a try, thank you @staabm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.