[TypeDeclaration] Add return static object support on ReturnTypeFromStrictFluentReturnRector#4916
Merged
samsonasik merged 5 commits intomainfrom Sep 5, 2023
Merged
[TypeDeclaration] Add return static object support on ReturnTypeFromStrictFluentReturnRector#4916samsonasik merged 5 commits intomainfrom
samsonasik merged 5 commits intomainfrom
Conversation
…trictFluentReturnRector
Member
Author
|
Github actions seems has issue showing latest commit, I just committed latest clean up commit but not shown, the change is Ready actually 👍 |
staabm
reviewed
Sep 5, 2023
| ClassMethod $classMethod, | ||
| ClassReflection $classReflection | ||
| ): ClassMethod { | ||
| $classMethod->returnType = $this->shouldSelf($classReflection) |
Contributor
There was a problem hiding this comment.
Maybe we could additionally add static phpdoc type on php7?
Member
Author
There was a problem hiding this comment.
That seems can be an improvement next 👍 with check not support static, but not final class and not anonymous class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@staabm continue of :
This will return static on php 8.x, and return self on php 7.x when it returns new static.
The
selfreturn is happen on:otherwise, it will return
static.