Conversation
|
Thank you @staabm |
| $containsWildcard = false; | ||
| foreach(self::REGEX_WILDCARD_CHARS as $char) { | ||
| if (str_contains($desiredName, $char)) { | ||
| $containsWildcard = true; | ||
| break; | ||
| } | ||
| } | ||
|
|
||
| if ($containsWildcard) { |
There was a problem hiding this comment.
When I see this method, I wonder if it should be doing regex check at all. It's a bit magical behavior from isName() and in 99.9 % cases never used.
Instead there should be matchName() method dedicated for this. I've run tests without it and it only reports ~10 fixtures.
There was a problem hiding this comment.
it would be great if we could reduce regex usage to only the necessary places.
after this change it no longer shows up in the memory focused profiles, but the method here is still the top1 method regarding CPU use - even after the PR
There was a problem hiding this comment.
Could you give the separated method a try?
There was a problem hiding this comment.
if you could give me a hint how to get rector running again :)
3 participants
see rectorphp/rector#8175 (comment)
blackfire suggest a reduction in memory usage by 67% per worker when running rector on the mautic codebase