Faster name resolving#4955
Merged
samsonasik merged 4 commits intorectorphp:mainfrom Sep 9, 2023
Merged
Conversation
Member
|
iirc, the total time is that should be seen, which 6 seconds faster instead of 80 seconds faster, you may looking using parallel so it collected for all processes time. That still improvement tho :) |
Contributor
Author
|
any suggestions regarding the last phpstan error? |
Member
|
move complex logic to private method should can reduce complexity |
Contributor
Author
|
I looked at the wrong method and was wondering what PHPStan is complaining about ;) |
samsonasik
approved these changes
Sep 9, 2023
Member
samsonasik
left a comment
There was a problem hiding this comment.
Lets give it a try, thank you @staabm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in the worker profiles of mautic I could see these rectors spending a lot of time in repeated name resolving.
I moved the name determination before the loop and used a lower level name-resolver method for comparison.
I did so only in the rectors which were reported in profiles
running on mautic..
before this PR
with this PR
-> 80 seconds faster