Update docblock only when changed, directly in rector rule#4986
Merged
TomasVotruba merged 3 commits intomainfrom Sep 11, 2023
Merged
Update docblock only when changed, directly in rector rule#4986TomasVotruba merged 3 commits intomainfrom
TomasVotruba merged 3 commits intomainfrom
Conversation
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
tv-narrow-abstract-8
branch
2 times, most recently
from
23b7a77 to
bf99a80
Compare
TomasVotruba
commented
Sep 11, 2023
| } | ||
| } | ||
|
|
||
| ?> |
Member
Author
There was a problem hiding this comment.
Already tested in another test fixture
TomasVotruba
force-pushed
the
tv-narrow-abstract-8
branch
from
33e4229 to
979bc04
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #4983
The comment/docblock management in
ClassPropertyAssignToConstructorPromotionRectorwould definitely deserve some cleanup :), but I'll leave that for now as hard to handle.Let's see what test fixtures will be reported.