Skip to content

Deprecated PhpDocInfo::markAsChanged() to ensure doc block is changed directly in the Rector rule #4987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 3 commits into from
Sep 11, 2023
Merged

Deprecated PhpDocInfo::markAsChanged() to ensure doc block is changed directly in the Rector rule #4987

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
54c862e
Deprecated PhpDocInfo::markAsChanged() to ensure doc block is changed…
TomasVotruba Sep 11, 2023
af579aa
remove unused markAsChanged() call
TomasVotruba Sep 11, 2023
4376fc5
remove double moveCommentsFromAttributeObjectToCommentsAttribute() run
TomasVotruba Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/BetterPhpDocParser/PhpDocInfo/PhpDocInfo.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,6 @@ public function addPhpDocTagNode(PhpDocChildNode $phpDocChildNode): void
$this->phpDocNode->children[] = $phpDocChildNode;
// to give node more space
$this->makeMultiLined();

$this->markAsChanged();
}

public function getPhpDocNode(): PhpDocNode
Expand Down Expand Up @@ -373,6 +371,7 @@ public function getTemplateTagValueNodes(): array
}

/**
* @deprecated Change doc block and print directly in the node instead
* @internal
* Should be handled by attributes of phpdoc node - if stard_and_end is missing in one of nodes, it has been changed
* Similar to missing original node in php-aprser
Expand Down
10 changes: 0 additions & 10 deletions src/PhpParser/Printer/BetterStandardPrinter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,16 +360,6 @@ protected function pScalar_String(String_ $string): string
return parent::pScalar_String($string);
}

/**
* @param Node[] $nodes
*/
protected function pStmts(array $nodes, bool $indent = true): string
{
$this->moveCommentsFromAttributeObjectToCommentsAttribute($nodes);

return parent::pStmts($nodes, $indent);
}

/**
* "...$params) : ReturnType"
* ↓
Expand Down