[Config] Move content of private method importFile() to import() method#5011
Merged
TomasVotruba merged 3 commits intomainfrom Sep 13, 2023
Merged
[Config] Move content of private method importFile() to import() method#5011TomasVotruba merged 3 commits intomainfrom
TomasVotruba merged 3 commits intomainfrom
Conversation
samsonasik
commented
Sep 13, 2023
Comment on lines
+226
to
+230
| if (str_contains($filePath, '*')) { | ||
| throw new ShouldNotHappenException( | ||
| 'Matching file paths by using glob($filePath) is no longer supported. Use specific file path instead.' | ||
| ); | ||
| } |
Member
Author
There was a problem hiding this comment.
@TomasVotruba @staabm @rmobis this is ensure user see the reason why * using glob on import no longer supported.
Contributor
There was a problem hiding this comment.
I had the same thing in mind - great!
Member
Author
|
All checks have passed 🎉 @TomasVotruba it is ready for review. |
staabm
reviewed
Sep 13, 2023
| ); | ||
| } | ||
|
|
||
| Assert::fileExists($filePath); |
Contributor
There was a problem hiding this comment.
not sure we need this fileExists call, as the require below will fail hard if the path is missing - not important though
Member
Author
There was a problem hiding this comment.
thats for throw exception for file not exists message consistency
staabm
reviewed
Sep 13, 2023
Co-authored-by: Markus Staab <markus.staab@redaxo.de>
Member
|
Thank you guys 👏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since asterisk support removed at PR:
call private method is no longer needed, this PR apply directly use the import code in the import method.