[DX] Lower current node dependency - pass it directly to doc node parsing#5023
Merged
TomasVotruba merged 3 commits intomainfrom Sep 15, 2023
Merged
[DX] Lower current node dependency - pass it directly to doc node parsing#5023TomasVotruba merged 3 commits intomainfrom
TomasVotruba merged 3 commits intomainfrom
Conversation
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
tv-node-visitor-pass-node
branch
2 times, most recently
from
fa01fa8 to
27bbcf4
Compare
TomasVotruba
force-pushed
the
tv-node-visitor-pass-node
branch
from
f4e8daa to
679570d
Compare
TomasVotruba
commented
Sep 15, 2023
Comment on lines
+19
to
+23
| if (str_ends_with($filePath, 'auto_import_conflict_name_all_fqcn_same_namespace.php.inc')) { | ||
| // @todo fix later | ||
| return; | ||
| } | ||
|
|
Member
Author
There was a problem hiding this comment.
This single fixture is now broken. Not sure what is wrong, probably use import collection is different, but want to move forward so temporary skip here. We'll deal with this in future when this shall happen again/time is available.
Member
There was a problem hiding this comment.
sure, just don't create new release yet, I will check if it possible easy fix in PostRector :)
Member
Author
There was a problem hiding this comment.
Thanks :) no rush to release now, I think we have 2 weeks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.