[TypeDeclaration] Handle fallback from param same type object on ReturnTypeFromReturnNewRector

[samsonasik]

@staabm this is to handle fallback from param on return new object:

final class FallbackFromParam
{
    public function action(SomeResponse $someResponse)
    {
        if (rand(0, 1)) {
            return new SomeResponse();
        }

        return $someResponse;
    }
}

[samsonasik]

implemented 🎉

[samsonasik]

@TomasVotruba the phpstan notice seems due to new phpstan-extensions release that cause invalid check on realpath() which can be false:

------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  packages/Caching/Detector/ChangedFilesDetector.php:90
 ------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  - '#Strict comparison using \=\=\= between string and false will always evaluate to false#'
 ------------------------------------------------------------------------------------------------------------------------------------------------------------------------

see symplify/phpstan-extensions@b2b82e1#r127599628

[samsonasik]

@TomasVotruba I created PR to symplify/phpstan-extensions to revert realpath:

• Remove realpath on NativeFunctionDynamicFunctionReturnTypeExtension symplify/phpstan-extensions#7

[staabm]

Do we need another test for a static and/or parent typed param?

[samsonasik]

static already error on the first place :)

• https://3v4l.org/cEZik

[samsonasik]

multiple return already skipped at

rector-src/rules/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromReturnNewRector.php

Lines 185 to 186 in c956f86

	$returnType = $this->returnTypeInferer->inferFunctionLike($node);
	if ($returnType instanceof UnionType) {

[samsonasik]

I updated to use @var string|false and check with more verbose is_dir() && is_file() in various locations based on @TomasVotruba suggestion at

symplify/phpstan-extensions@b2b82e1#r127599628

[samsonasik]

All checks have passed 🎉 @TomasVotruba I think it is ready.

[staabm]

We should do this cheap chrck earlier

[samsonasik]

updated 8fae378

[samsonasik]

All checks have passed 🎉 @TomasVotruba I am merging it to have faster feedback to test ;)

[TomasVotruba]

This will be always string, as we use existing set paths:

            $setRealpath = realpath($setFile);
            $relativeFilePath = Strings::after($setRealpath, getcwd() . '/');

[samsonasik]

sure, I updated at :

• Use realpath() as string on MissingInSetCommand #5040

[TomasVotruba]

Thanks 👏

[staabm]

the php process might still not be able to read this file (e.g. because of filesystem persmissions) and return false?

[samsonasik]

@staabm that's what I thought, but since tools/ directory is not shipped to rector/rector, I guess it safe for user, the concern is probably when directory/set removed in the future and not detected.

The better solution is probably use:

Assert::string($setRealpath);

so it will be detected early when path removed/renamed.

[staabm]

Thanks 🙏